Differences

This shows you the differences between two versions of the page.

--- technology:opinions:abiasedguidetounittests [2021/09/06 22:34] – Owen Mellema
+++ technology:opinions:abiasedguidetounittests [2021/09/06 22:52] (current) – Owen Mellema
@@ Line 323: / Line 323: @@
 //Feed packaged input into SUT
-FibonacciResponse packagedOutput = Fibonacci.fib3(fibonacciCriteria);
+FibonacciResponse packagedOutput = Fibonacci.fib(fibonacciCriteria);
 //Create a packaged expected output.
@@ Line 413: / Line 413: @@
 </code>
 ==== Effective abstraction ====
-Here's a few ideas for cleaning up your tests with abstraction.
+Here's a few ideas for cleaning up your tests with abstraction. Remember, in all of this, the name of the game is //readable//, not //convenient//! All decisions regarding cleaning must be made with an eye for the reader.
   * Do as little packaging in your setup methods as possible. Instead, move the heavy lifting of packaging to dedicated private methods, like this:
 <code:java>
@@ Line 449: / Line 449: @@
 </code>
   * Don't abstract away the actual calling of the SUT. After all, that's the most important part.
+  * Writing helper assertion methods can be helpful, but they can also confuse readers if not done right. Follow these tips to write a good helper assert.
+    * Your assertion should take two arguments at most (excluding housekeeping arguments like "delta" for comparing floats)
+    * The first argument should be the packaged output, and the second argument should be the primitive to test.
+    * The name of the helper should begin with "assert", followed by the concept being tested. Don't use the word "correct", it's redundant.
+    * All asserts in the helper assertion method should be conceptually related. If possible, use just one.
+<code:java>
+@Test
+void thenResultIs0() {
+    assertResult(response, 0);
+}
+private void assertResult(FibonacciResponse response, int expectedResult)
+{
+    int result = response.getResult();
+    assertEquals(expectedResult, result);
+}
+</code>